-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(storagenode): remove backup from append request #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 11, 2023
This was referenced Apr 11, 2023
ijsong
force-pushed
the
remove_backup_from_append_request
branch
from
April 13, 2023 13:23
b1e0982
to
4e18b9d
Compare
ijsong
force-pushed
the
remove_backup_from_append_request
branch
from
April 13, 2023 13:43
4e18b9d
to
063890f
Compare
hungryjang
reviewed
Apr 14, 2023
ijsong
force-pushed
the
remove_backup_from_append_request
branch
from
April 15, 2023 13:18
063890f
to
b620d36
Compare
ijsong
force-pushed
the
remove_backup_from_append_request
branch
from
April 25, 2023 12:13
b620d36
to
c857535
Compare
ijsong
force-pushed
the
remove_backup_from_append_request
branch
from
May 16, 2023 14:54
c857535
to
0fa973d
Compare
This was referenced May 16, 2023
hungryjang
approved these changes
Jun 1, 2023
This PR removes the Backups fields from AppendRequest. Thus, it makes unmarshaling AppendRequest can be improved.
ijsong
force-pushed
the
remove_backup_from_append_request
branch
from
June 1, 2023 03:31
0fa973d
to
f75ef55
Compare
This was referenced Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR removes the Backups fields from AppendRequest. Thus, it makes unmarshaling AppendRequest can
be improved.