perf(storagenode): wrap replicateTask slice with struct #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
==========================================
- Coverage 63.56% 63.55% -0.02%
==========================================
Files 131 131
Lines 17809 17811 +2
==========================================
- Hits 11321 11319 -2
- Misses 5944 5945 +1
- Partials 544 547 +3
... and 7 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ijsong
force-pushed
the
replicate_task_slice
branch
from
bf5fb22
to
7add8f4
Compare
hungryjang
approved these changes
Apr 14, 2023
The `replicateTaskSlicePool` pooled slices of `replicateTask`. The function `releaseReplicateTaskSlice` received borrowed slice and then put it into `replicateTaskSlicePool`. However, the `sync.(Pool).Put` parameter is an interface, so the slice escaped to the heap unnecessarily. Not to use unnecessary heap objects, this PR wraps the `replicateTask` slice with the struct replicateTaskSlice. Resolves #75
ijsong
force-pushed
the
replicate_task_slice
branch
from
7add8f4
to
37250e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
The
replicateTaskSlicePoolpooled slices ofreplicateTask. The functionreleaseReplicateTaskSlicereceived borrowed slice and then put it intoreplicateTaskSlicePool.However, the
sync.(Pool).Putparameter is an interface, so the slice escaped to the heapunnecessarily.
Not to use unnecessary heap objects, this PR wraps the
replicateTaskslice with the structreplicateTaskSlice.
Which issue(s) this PR resolves
Resolves #75