Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storagenode): add LogStreamReplicaMetadata to /varlog.snpb.LogIO to replace LogStreamMetadata #140

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Sep 12, 2022

What this PR does

Add /varlog.snpb.LogIO/LogStreamReplicaMetadata to replace
/varlog.snpb.LogIO/LogStreamMetadata. The LogStreamMetadata returns
proto/varlogpb/LogStreamDescriptor that have deprecated fields Head and
Tail. Instead, the LogStreamReplicaMetadata returns
proto/snpb/LogStreamReplicaMetadataDescriptor that is proper to the intend of
RPC.

Which issue(s) this PR resolves

Ref: #73

Anything else


This change is Reviewable

@ijsong ijsong self-assigned this Sep 12, 2022
@ijsong ijsong force-pushed the add-log-stream-replica-metadata branch from 4ff870f to 926348d Compare September 12, 2022 06:23
@codecov-commenter
Copy link

Codecov Report

Merging #140 (926348d) into main (c4d0c8d) will decrease coverage by 0.24%.
The diff coverage is 41.53%.

@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
- Coverage   62.83%   62.59%   -0.25%     
==========================================
  Files         125      125              
  Lines       16883    16996     +113     
==========================================
+ Hits        10609    10638      +29     
- Misses       5727     5804      +77     
- Partials      547      554       +7     
Impacted Files Coverage Δ
internal/storagenode/client/log_client.go 45.37% <0.00%> (-3.72%) ⬇️
internal/storagenode/log_server.go 41.05% <0.00%> (-4.83%) ⬇️
pkg/varlog/log.go 0.00% <0.00%> (ø)
pkg/varlog/operations.go 0.00% <0.00%> (ø)
proto/snpb/metadata.go 0.00% <0.00%> (ø)
pkg/varlogtest/log.go 71.46% <70.58%> (-0.15%) ⬇️
pkg/varlogtest/admin.go 42.03% <85.71%> (+0.61%) ⬆️
internal/storagenode/logstream/executor.go 75.94% <0.00%> (-1.90%) ⬇️
internal/storagenode/logstream/committer.go 81.85% <0.00%> (-1.07%) ⬇️
internal/metarepos/report_collector.go 77.86% <0.00%> (-0.81%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

…b.LogIO` to replace `LogStreamMetadata`

Refs: #73
@ijsong ijsong force-pushed the add-log-stream-replica-metadata branch from 926348d to 1ce7ec6 Compare September 12, 2022 11:13
@hungryjang hungryjang self-requested a review September 13, 2022 00:10
@ijsong ijsong merged commit 543c854 into kakao:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants