Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(storagenode): wrap replicateTask slice with struct #416

Merged
merged 1 commit into from
Apr 15, 2023
Merged

perf(storagenode): wrap replicateTask slice with struct #416

merged 1 commit into from
Apr 15, 2023

Commits on Apr 15, 2023

  1. perf(storagenode): wrap replicateTask slice with struct 

    The `replicateTaskSlicePool` pooled slices of `replicateTask`. The function
`releaseReplicateTaskSlice` received borrowed slice and then put it into `replicateTaskSlicePool`.
However, the `sync.(Pool).Put` parameter is an interface, so the slice escaped to the heap
unnecessarily.

Not to use unnecessary heap objects, this PR wraps the `replicateTask` slice with the struct
replicateTaskSlice.

Resolves #75
    @ijsong
    ijsong committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    37250e1 View commit details
    Browse the repository at this point in the history