Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(metarepos): do not use unnecessary labels #445

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented May 16, 2023

What this PR does

Because the metadata repository sets node id as resource service.instance.id, it does not need to
use a redundant label - nodeid.

Which issue(s) this PR resolves

Resolve #423

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 77.77% and project coverage change: -0.10 ⚠️

Comparison is base (39fcf2e) 63.33% compared to head (626fe12) 63.24%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           append_batchlet_size     #445      +/-   ##
========================================================
- Coverage                 63.33%   63.24%   -0.10%     
========================================================
  Files                       131      131              
  Lines                     17948    17914      -34     
========================================================
- Hits                      11368    11329      -39     
- Misses                     6016     6017       +1     
- Partials                    564      568       +4     
Impacted Files Coverage Δ
internal/metarepos/report_collector.go 77.33% <0.00%> (-0.10%) ⬇️
internal/metarepos/raft.go 79.74% <100.00%> (-0.15%) ⬇️
internal/metarepos/raft_metadata_repository.go 76.99% <100.00%> (-0.63%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Because the metadata repository sets node id as resource `service.instance.id`, it does not need to
use a redundant label - `nodeid`.

Resolve #423
@ijsong
Copy link
Member Author

ijsong commented Jun 1, 2023

@ijsong started a stack merge that includes this pull request via Graphite.

Base automatically changed from append_batchlet_size to main June 1, 2023 05:27
@ijsong ijsong merged commit 3d7ff30 into main Jun 1, 2023
@ijsong ijsong deleted the mr_remove_otel_label branch June 1, 2023 05:27
@ijsong
Copy link
Member Author

ijsong commented Jun 1, 2023

@ijsong merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metarepos: avoid unnecessary stringification
3 participants