-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(metarepos): do not use unnecessary labels #445
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## append_batchlet_size #445 +/- ##
========================================================
- Coverage 63.33% 63.24% -0.10%
========================================================
Files 131 131
Lines 17948 17914 -34
========================================================
- Hits 11368 11329 -39
- Misses 6016 6017 +1
- Partials 564 568 +4
☔ View full report in Codecov by Sentry. |
Because the metadata repository sets node id as resource `service.instance.id`, it does not need to use a redundant label - `nodeid`. Resolve #423
39fcf2e
to
3c91b62
Compare
626fe12
to
0d5c17a
Compare
What this PR does
Because the metadata repository sets node id as resource
service.instance.id
, it does not need touse a redundant label -
nodeid
.Which issue(s) this PR resolves
Resolve #423