Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(metarepos): add mrpb.StorageNodeUncommitReport pool #446

Merged
merged 1 commit into from
Jun 1, 2023

Commits on Jun 1, 2023

  1. perf(metarepos): add mrpb.StorageNodeUncommitReport pool

    This patch adds an `mrpb.StorageNodeUncommitReport` pool, which is
    `proto/mrpb.storageNodeUncommitReportPool`. It reduces heap objects allocated repeatedly whenever
    processing reports received from storage nodes.
    
    Below heap profiling is the previous result.
    
    ```
          flat  flat%   sum%        cum   cum%
      70865580  8.38% 44.73%   71293773  8.43%  github.com/kakao/varlog/internal/metarepos.(*reportCollectExecutor).processReport
    ```
    
    Now here it is after applying this patch.
    
    ```
          flat  flat%   sum%        cum   cum%
      20734504  2.10% 75.92%   42122814  4.26%  github.com/kakao/varlog/internal/metarepos.(*reportCollectExecutor).processReport
    ```
    ijsong committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    4c624da View commit details
    Browse the repository at this point in the history