test(benchmark): support log stream appender #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 2, 2023
This was referenced Jun 2, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
|
The current lint failure will be fixed soon: |
ijsong
force-pushed
the
log_stream_appender
branch
from
05f590e
to
ea02918
Compare
ijsong
force-pushed
the
benchmark_log_stream_appender
branch
from
763e20d
to
e6b68f9
Compare
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## log_stream_appender #462 +/- ##
=======================================================
+ Coverage 62.66% 62.69% +0.03%
=======================================================
Files 133 133
Lines 18336 18336
=======================================================
+ Hits 11490 11496 +6
+ Misses 6271 6267 -4
+ Partials 575 573 -2 ☔ View full report in Codecov by Sentry. |
ijsong
force-pushed
the
log_stream_appender
branch
from
ea02918
to
f8a7676
Compare
ijsong
force-pushed
the
benchmark_log_stream_appender
branch
from
e6b68f9
to
53b2258
Compare
hungryjang
approved these changes
Jun 7, 2023
This PR adds the `--pipeline-size` flag to the benchmark tool. It makes the benchmark test client use LogStreamAppender, which allows pipelined append requests. - No pipelined requests if the flag is zero (default value). - Use pipelined requests by using LogStreamAppender if the flag is greater than zero. The benchmark tool cannot support per-target level pipelined yet. Thus, if the `--pipeline-size` is greater than zero, all the log stream-specific targets will use LogStreamAppender.
|
Graphite rebased this pull request as part of a merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds the
--pipeline-sizeflag to the benchmark tool. It makes the benchmark test client use LogStreamAppender, which allows pipelined append requests.The benchmark tool cannot support per-target level pipelined yet. Thus, if the
--pipeline-sizeis greater than zero, all the log stream-specific targets will use LogStreamAppender.