Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify get_version.sh to deal better with whitespace (avoid space in … #1526

Merged
merged 1 commit into from
Apr 2, 2017

Conversation

danpovey
Copy link
Contributor

@danpovey danpovey commented Apr 2, 2017

…version); minor fixes

@dogancan, this is because I was getting whitespace in the version string on mac:

WARNING ([5.1.      44~       1-cfd87]:Check():convolution.cc:197) the input at the 3'th height is never used.

@dogancan
Copy link
Contributor

dogancan commented Apr 2, 2017

It seems the BSD version of the wc utility prints extra space before printing the counts. I did not notice this on my end since I am using GNU coreutils on Mac. My bad.

@danpovey danpovey merged commit 60f9327 into kaldi-asr:master Apr 2, 2017
kronos-cm added a commit to kronos-cm/kaldi that referenced this pull request Apr 5, 2017
* 'master' of https://github.com/kaldi-asr/kaldi:
  [src] Cosmetic change: remove 'train.tra' from usage messages (kaldi-asr#1529)
  [src] cudamatrix: speed up AddColSumMat with transfrom reduce kernel template (kaldi-asr#1530)
  [build]: remove openfst check (kaldi-asr#1531)
  [build,src,doc] Modify get_version.sh to deal better with whitespace (avoid space in version); minor fixes (kaldi-asr#1526)
  [scripts,egs] Adding options for using PCA instead of LDA+MLLT for ivectors used in ASR. Results are reported in the default TDNN recipe in AMI. Updating steps/online/nnet2/{train_diag_ubm.sh,train_ivector_extractor.sh} so that they now backup the contents of their destination directory if it already exists. (kaldi-asr#1514)
  [src] (minor) Added missing SetZero() to NaturalGradientAffineComponent::Scale() if scale==0.0 (kaldi-asr#1522)
  [src,doc] Fix several unrelated minor problems.  Thanks: gaoxinglong
  [src] Adding noexcept to hashing function objects (kaldi-asr#1519)
  [egs] Fix to egs/wsj/s5/run.sh (unset variable) (kaldi-asr#1517)
  [misc] remove eXecute permissions where not needed (kaldi-asr#1515)
  [src,scripts]: Several unrelated cosmetic changes
  [egs] fixes to babel pipeline; thanks to Fred Richardson (kaldi-asr#1509)
  [src] Fix exit code of extract-rows.cc (kaldi-asr#1510)
david-ryan-snyder pushed a commit to david-ryan-snyder/kaldi that referenced this pull request Apr 12, 2017
Skaiste pushed a commit to Skaiste/idlak that referenced this pull request Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants