Cats Effect 3.x initial implementation #1128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cmcmteixeira please take a look at this issue when trying to compile for Scala 2.11 |
|
There is not support for scala 2.11. |
hughsimpson
reviewed
Mar 14, 2022
| @@ -242,9 +242,9 @@ lazy val `kamon-cats-io` = (project in file("instrumentation/kamon-cats-io")) | |||
| kanelaAgent % "provided", | |||
| { | |||
| if(scalaBinaryVersion.value == "2.11") | |||
| "org.typelevel" %% "cats-effect" % "2.0.0" % "provided" | |||
| "org.typelevel" %% "cats-effect" % "3.3.5" % "provided" | |||
There was a problem hiding this comment.
I think it might be saner to split this into kamon-cats-effect2/kamon-cats-effect-3 ? I'm picturing people on cats effect 2 bumping kamon and suddenly their instrumentation breaks
There was a problem hiding this comment.
Probably the best way to go indeed.. Just gotta make it work first 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details can be found here