Skip to content

Commit

Permalink
Minor corrections
Browse files Browse the repository at this point in the history
  • Loading branch information
@zaychenko-sergei
zaychenko-sergei committed Nov 26, 2024
1 parent 76205b4 commit 4fa8b68
Show file tree
Hide file tree
Showing 5 changed files with 247 additions and 207 deletions.
1 change: 1 addition & 0 deletions src/adapter/graphql/tests/tests/mod.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ mod test_gql_dataset_flow_runs;
mod test_gql_datasets;
mod test_gql_metadata;
mod test_gql_metadata_chain;
mod test_gql_remote_statuses;
mod test_gql_search;
mod test_guards;
mod test_update_schema;
198 changes: 0 additions & 198 deletions src/adapter/graphql/tests/tests/test_gql_metadata.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,22 +7,16 @@
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0.

use std::sync::Arc;

use async_graphql::*;
use database_common::NoOpDatabasePlugin;
use dill::*;
use indoc::indoc;
use internal_error::InternalError;
use kamu::testing::MetadataFactory;
use kamu::*;
use kamu_core::utils::metadata_chain_comparator::CompareChainsResult;
use kamu_core::*;
use messaging_outbox::DummyOutboxImpl;
use opendatafabric::*;
use tempfile::TempDir;
use time_source::SystemTimeSourceDefault;
use url::Url;

use crate::utils::authentication_catalogs;

Expand Down Expand Up @@ -175,196 +169,4 @@ async fn test_current_push_sources() {
);
}

#[test_log::test(tokio::test)]
async fn test_push_statuses() {
let harness = PushStatusesTestHarness::new();

// Init dataset with no sources
let (_, catalog_authorized) = authentication_catalogs(&harness.base_catalog).await;

let create_dataset_from_snapshot = catalog_authorized
.get_one::<dyn CreateDatasetFromSnapshotUseCase>()
.unwrap();
let create_result = create_dataset_from_snapshot
.execute(
MetadataFactory::dataset_snapshot()
.kind(DatasetKind::Root)
.name("foo")
.build(),
Default::default(),
)
.await
.unwrap();

let request_code = indoc!(
r#"
{
datasets {
byId (datasetId: "<id>") {
metadata {
pushSyncStatuses {
statuses {
remote,
result {
... on CompareChainsResultStatus { message }
... on CompareChainsResultError { reason { message } }
}
}
}
}
}
}
}
"#
)
.replace("<id>", &create_result.dataset_handle.id.to_string());

let schema = kamu_adapter_graphql::schema_quiet();
let res = schema
.execute(Request::new(request_code.clone()).data(catalog_authorized.clone()))
.await;

assert!(res.is_ok(), "{res:?}");

let expected = value!({
"datasets": {
"byId": {
"metadata": {
"pushSyncStatuses": {
"statuses": [
{
"remote": "https://example.com/ahead",
"result": {
"message": "AHEAD"
}
},
{
"remote": "https://example.com/behind",
"result": {
"message": "BEHIND"
}
},
{
"remote": "https://example.com/diverged",
"result": {
"message": "DIVERGED"
}
},
{
"remote": "https://example.com/equal",
"result": {
"message": "EQUAL"
}
},
{
"remote": "https://example.com/not-found",
"result": {
"reason": {
"message": "Remote dataset not found"
}
}
}
]
}
}
}
}
});
assert_eq!(res.data, expected);
}

////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

struct PushStatusesTestHarness {
base_catalog: Catalog,
_tempdir: TempDir,
}

impl PushStatusesTestHarness {
fn new() -> Self {
let tempdir = tempfile::tempdir().unwrap();
let datasets_dir = tempdir.path().join("datasets");
std::fs::create_dir(&datasets_dir).unwrap();

let base_catalog = {
let mut b = CatalogBuilder::new();

b.add_value(RunInfoDir::new(tempdir.path().join("run")))
.add::<DummyOutboxImpl>()
.add_builder(DatasetRepositoryLocalFs::builder().with_root(datasets_dir))
.bind::<dyn DatasetRepository, DatasetRepositoryLocalFs>()
.bind::<dyn DatasetRepositoryWriter, DatasetRepositoryLocalFs>()
.add::<CreateDatasetFromSnapshotUseCaseImpl>()
.add::<SystemTimeSourceDefault>()
.add::<DatasetRegistryRepoBridge>()
.add_value(TenancyConfig::SingleTenant)
.add_value(FakeRemoteStatusService {})
.bind::<dyn RemoteStatusService, FakeRemoteStatusService>();

NoOpDatabasePlugin::init_database_components(&mut b);

b.build()
};

Self {
base_catalog,
_tempdir: tempdir,
}
}
}

////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

pub struct FakeRemoteStatusService {}

#[async_trait::async_trait]
impl RemoteStatusService for FakeRemoteStatusService {
async fn check_remotes_status(
&self,
_dataset_handle: &DatasetHandle,
) -> std::result::Result<DatasetPushStatuses, InternalError> {
Ok(DatasetPushStatuses {
statuses: vec![
PushStatus {
remote: DatasetRefRemote::Url(Arc::new(
Url::parse("https://example.com/ahead").unwrap(),
)),
check_result: Ok(CompareChainsResult::LhsBehind {
rhs_ahead_blocks: vec![],
}),
},
PushStatus {
remote: DatasetRefRemote::Url(Arc::new(
Url::parse("https://example.com/behind").unwrap(),
)),
check_result: Ok(CompareChainsResult::LhsAhead {
lhs_ahead_blocks: vec![],
}),
},
PushStatus {
remote: DatasetRefRemote::Url(Arc::new(
Url::parse("https://example.com/diverged").unwrap(),
)),
check_result: Ok(CompareChainsResult::Divergence {
uncommon_blocks_in_lhs: 0,
uncommon_blocks_in_rhs: 0,
}),
},
PushStatus {
remote: DatasetRefRemote::Url(Arc::new(
Url::parse("https://example.com/equal").unwrap(),
)),
check_result: Ok(CompareChainsResult::Equal),
},
PushStatus {
remote: DatasetRefRemote::Url(Arc::new(
Url::parse("https://example.com/not-found").unwrap(),
)),
check_result: Err(StatusCheckError::RemoteDatasetNotFound),
},
],
})
}
}

////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
Loading

0 comments on commit 4fa8b68

Please sign in to comment.