-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add browserShadowBlurConstant to adjust shadowBlur value #4413
Conversation
would you mind check if there are some tests of setShadow in the object tests and in case add one that demostrate that this thing works? i can guide you. |
Yeah in fact I tried to run the tests by following the Readme but when running |
use |
remove that npm install quint -g that you did before and reinstall fabric? |
What do you mean by "reinstall fabric" ?
=> Still have the same error. (I see you opened a PR specifically for this, I guess it should ring a bell?) Then I just tried to patch QUnit with
Note: I'm using Node v8.8.0 |
Skipped all tests but Added a simple test, tell me if it's enough. Thanks |
If you have trouble running image tests it does me bring to think you have problem installing node-canvas. |
test is ok, i just added descriptions so that if it fails you know what failed. if i did not broke linting i m going merge right now. |
Expose browserShadowBlurConstant to adjust shadowBlur value
close #4402