Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runs-on to the publish_chart job #3189

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Add runs-on to the publish_chart job #3189

merged 1 commit into from
Oct 18, 2024

Conversation

pavannd1
Copy link
Contributor

@pavannd1 pavannd1 commented Oct 18, 2024

Change Overview

Missed adding runs-on when fixing the bug in #3187

[Invalid workflow file: .github/workflows/release.yaml#L115](https://github.com/kanisterio/kanister/actions/runs/11411652685/workflow)
The workflow is not valid. .github/workflows/release.yaml (Line: 115, Col: 5): Required property is missing: runs-on

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test
  • 🏗️ Build

Issues

  • fixes #issue-number

Test Plan

The workflow got triggered when releasing a new version and failed. Once we merge this, I will re-trigger the failed workflow.
Not testing this separately on a branch due to time constraints.

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@pavannd1 pavannd1 merged commit 0f62e04 into master Oct 18, 2024
16 of 17 checks passed
@pavannd1 pavannd1 deleted the fix-publish-chart-2 branch October 18, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants