Replace many minor usages of errors with errkit #3228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-sumin
force-pushed
the
errkit_migration_8_remainder
branch
4 times, most recently
from
8948f80
to
2fa1f65
Compare
e-sumin
force-pushed
the
errkit_migration_8_remainder
branch
8 times, most recently
from
5e32677
to
3ff70e5
Compare
e-sumin
force-pushed
the
errkit_migration_8_remainder
branch
from
3ff70e5
to
23241c5
Compare
|
@e-sumin can you split it into several PRs? 79 files is a bit too much to review all at once. Can be arbitrary if they don't depend on each other. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Bunch of changes in different small packages
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan