Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rm hardcoded useIframe & captureConsole opts #194

Merged
merged 1 commit into from
Jul 11, 2016
Merged

fix: rm hardcoded useIframe & captureConsole opts #194

merged 1 commit into from
Jul 11, 2016

Conversation

gnail
Copy link
Contributor

@gnail gnail commented Jun 28, 2016

These default options will override karma.conf.js even if they're explicitly set to false in there. This was kinda pointless anyway since Karma defaults these options to true anyway if they are not set.

Closes #165, #166

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@gnail
Copy link
Contributor Author

gnail commented Jun 28, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@gnail
Copy link
Contributor Author

gnail commented Jun 28, 2016

This PR will also close #128

@dignifiedquire
Copy link
Member

Thanks will merge and release when the relevant karma PR is merged and released

@dignifiedquire
Copy link
Member

@gnail in the meantime could you please change the commit message to follow our convention. Thanks

These default options will override karma.conf.js even if they're explicitly set to false in there. This was kinda pointless anyway since Karma defaults these options to true anyway if they are not set.

Closes #165, #166
@gnail
Copy link
Contributor Author

gnail commented Jul 10, 2016

Ok I've updated the commit messages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants