From a1478bde53433569193c4e7f4c8761fb4c691bff Mon Sep 17 00:00:00 2001
From: Keen Yee Liau <kyliau@google.com>
Date: Fri, 15 Jun 2018 11:21:40 -0700
Subject: [PATCH] feat(preprocessor): Allow preprocessor to handle binary files

---
 lib/preprocessor.js | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/lib/preprocessor.js b/lib/preprocessor.js
index 7d1c8bfb4..fae280c80 100644
--- a/lib/preprocessor.js
+++ b/lib/preprocessor.js
@@ -98,12 +98,7 @@ function createPreprocessor (config, basePath, injector) {
         var preprocessorNames = []
         for (var i = 0; i < patterns.length; i++) {
           if (mm(file.originalPath, patterns[i], {dot: true})) {
-            if (thisFileIsBinary) {
-              log.warn('Ignoring preprocessing (%s) %s because it is a binary file.',
-                config[patterns[i]].join(', '), file.originalPath)
-            } else {
-              preprocessorNames = combineLists(preprocessorNames, config[patterns[i]])
-            }
+            preprocessorNames = combineLists(preprocessorNames, config[patterns[i]])
           }
         }
 
@@ -125,7 +120,12 @@ function createPreprocessor (config, basePath, injector) {
           }
 
           instances[name] = p
-          preprocessors.push(p)
+          if (!thisFileIsBinary || p.handleBinaryFiles) {
+            preprocessors.push(p)
+          } else {
+            log.warn('Ignoring preprocessing (%s) %s because it is a binary file.',
+              name, file.originalPath)
+          }
         })
 
         nextPreprocessor(null, thisFileIsBinary ? buffer : buffer.toString())