-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Determine if full page reload error is obsolete #1656
Determine if full page reload error is obsolete #1656
Comments
No it's not obsolete, if that is the case that means our fixes our not working as intended. I'm afraid I will have to roll back to the earlier version then for now until we figure out a better way :( |
@dignifiedquire This appears to be an issue with jasmine-core. Refer to jasmine/jasmine#366 and jasmine/jasmine#945 |
@FuzzySockets thanks for digging into this! |
So, it looks like a jasmine-core issue? I'm seeing this on one environment but not another. |
I'm seeing this issue intermittently from Chrome when running a large (5000+) test suite in multiple browsers (Chrome, Firefox, and PhantomJS). Using the latest version of Karma. |
Hi, is there any intention to do this today? I am seeing this error when using Karma + Mocha as well. |
I found something interesting if you run the tests separate:
then this page reload error does not occur, however this solution results in longer test run times, since they are executed twice |
still an issue |
This sounds like a valid bug to me. However, there have been many changes to the library since it was reported. Please open a new issue including a minimal reproduction if you still experience this problem. |
@dignifiedquire After the previous fixes to the reloadingContext flag, I'm unable to trigger the full page reload error at all regardless of what I put in my jasmine tests. I've tried causing a page reload via window.location.reload(), window.location.href = '', window.location.assign, etc... None of these trigger the error.
Did our fixes to the reloadingContext flag break some important behavior? Or is the full page reload error (Some of your tests did a full page reload!) now obsolete?
The text was updated successfully, but these errors were encountered: