Launcher - ignore exit code after killing

[vojtajina]

Once the launcher gets into state BEING_KILLED or BEING_TIMEOUTED, ignore the exit code.

http://nodejs.org/api/child_process.html#child_process_event_close
Most of the browsers returns "not-normally" (because of receiving a signal) and therefore exit event gets null exit code. But PhantomJS exits "normally" with status code 1 (after receiving TERM signal):
Medium/phantomjs@8921fb7

[acjcm3c]

I second this feature since it is giving us an ERROR [launcher]: Cannot start PhantomJS when we run our tests with karma

[mnichols]

Yes I can confirm this on my Mac OSX 10.8. My tests run and indicate SUCCESS or FAILUREs but then I get the ERROR [launcher] message

[icecreamliker]

It happened on my ubuntu 12.04.
Do you have some advice? or I should modify the source code of PhantomJS?

[oleastre]

As said by email, I can confirm this problem with PhantomJS 1.8 on fedora 18 and ubuntu 12.04.

For those that are blocked by this problem, a quick workaround is to modify the PhantomJS launcher to return 0 instead of 1 (see the phantomJS commit).

On the long term, the exit code can be ignored when being killed (or karma can handle the specific phantomJS case).

[leostera]

👍 to @mnichols, same system here, same issue.

Running tests works thou.

[swallentin]

I'm experiencing the very same problem, my tests run and pass but "build" fails.

PhantomJS 1.9 (Mac): Executed 1 of 1 SUCCESS (1.156 secs / 1.067 secs)
ERROR [launcher]: Cannot start PhantomJS

I'm on Mountain Lion using phantomjs 1.9.0.