feat(config): Add configuration for javascript version. #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,9 +60,21 @@ var getXUACompatibleUrl = function (url) { | |||
| return value | |||
| } | |||
|
|
|||
| function applyJavascriptVersionTag (req) { | |||
There was a problem hiding this comment.
Better name would be isFirefox or hasJsVersionTags
…, intelligently merge the list of preprocessors, deduping and trying to preserve the order This could be a breaking change, some users might rely on the old order, or on some preprocessors being run multiple times
Change information on how to use node.js on Windows
The javascript version tag would only be applied to the Firefox browser.
Moumi
force-pushed
the
feature-javascript-version-tag-firefox
branch
from
91102e0
to
78320db
Compare
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
…, intelligently merge the list of preprocessors, deduping and trying to preserve the order This could be a breaking change, some users might rely on the old order, or on some preprocessors being run multiple times
Change information on how to use node.js on Windows
feat(config): Add configuration for adding a javascript version.
…ub.com/delftswa2016/karma into feature-javascript-version-tag-firefox
|
This PR is getting a bit messy. Closing it to create a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration for a javascript version tag. This tag is only applied to Firefox (now).
Closes #1719