From 7b0c1781ce41ae01a2b380a37efae7d2fc6c475b Mon Sep 17 00:00:00 2001 From: Kasper <805006+kasper573@users.noreply.github.com> Date: Thu, 4 Jul 2024 07:52:28 +0200 Subject: [PATCH] ci: build job should build for production --- .github/workflows/build_and_test.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index 2b3f8901..52eb4de9 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -37,8 +37,8 @@ jobs: - uses: ./.github/workflows/composites/install/ - run: pnpm build env: - # We can only build for development in CI, - # since production settings and builds are handled externally (e.g. by Vercel). - # This CI job is only for sanity testing the build process in the CI. - NODE_ENV: development + NODE_ENV: production + # No additional application specific environment variables should be provided here or in the CI. + # Application environment variables should be provided by the external deployment build system. + # (Providing no environment variables here also ensures that all apps support being built with zero config) - run: pnpm typecheck