This repository has been archived by the owner on May 12, 2021. It is now read-only.
mount: Log params and validate #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate mount parameters where possible and log all parameters to help debug scenarios where the client gRPC protocol is out-of-sync with the agents (master) version. Added a new test for `mount()`. Fixes kata-containers#170. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
sboeuf
approved these changes
Mar 15, 2018
|
Thanks for adding this necessary check here. |
|
CI failing due to another vendoring issue by the looks of it: That looks like the gRPC /cc @sboeuf. |
|
@jodh-intel yeah we know we have to fix things first. All the PR on this repo are gonna fail until then. |
|
As an FYI this failed for me when I setup Kata containers from source on 3/16 |
|
Hi @eadamsintel - we're taking further steps to avoid this happening in future. See: |
|
Tests passing so this is ready for review. |
|
lgtm |
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate mount parameters where possible and log all parameters to help
debug scenarios where the client gRPC protocol is out-of-sync with the
agents (master) version.
Added a new test for
mount().Fixes #170.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com