-
Notifications
You must be signed in to change notification settings - Fork 85
Conversation
Hi @ygefen - thanks for persisting here! 😄 I'm afraid that Travis is still failing so you may have caught it at the wrong time. The failure is unrelated to your change but please can you rebase and re-push again: $ git checkout master
$ git pull
$ git checkout doc-patch
$ git rebase -i master
$ git push -f Note that you don't need to close this PR and open a new one - just do a force re-push as shown above: Also, pullapprove is complaining about your commit. I think this is since the email address you've specified in the commit doesn't match your default github email address. I appreciate this is a small fix and this is a bit of work all for a 1 byte change. However, we do value every contribution! |
Correct rootfs builder link in the image builder README. Fixes kata-containers#185. Signed-off-by: Yonatan Gefen <yoni.gefen@gmail.com>
Thank you for guiding me through this, regardless of how minor of a fix it is. |
Hmm, seems to fail again. But I'm pretty sure I rebased properly, could I have made a mistake? |
hi @ygefen hmm, yeah, that is still failing on the
In this instance, we may have to do a hand-review and then force merge it in - let me have a peek at the code to review, and /cc @chavafg in case he has some ideas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
:-)
If it's easier/cleaner I can redo the fork, branch, & PR so that you don't have to bypass your CI. It should only take me a minute given the simplicity of this change. |
Hi @ygefen - thanks for updating! The Travis issue is rather subtle and since it has nothing to do with your fix, I'm going to merge this PR. If you want to know the details, the problem is that the osbuilder repo is not setup as a golang project. Due to this, Travis installs the default version of golang which is too old for the For the osbuilder repo, we have two options:
|
Correct rootfs builder link in the image builder README.
Fixes #185.
Signed-off-by: Yonatan Gefen yoni.gefen@gmail.com