Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Commit

Permalink
shimv2 : Remove workaround for sharedPidNs
Browse files Browse the repository at this point in the history
Removing code that existed as a workaround for a bug in
how shared process namespaces were handled in the agent.
That has been long fixed in the agent.
With this, sharedPidNs will now work with shimv2.

Fixes #2788

Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
  • Loading branch information
amshinde committed Jun 25, 2020
1 parent ea74c96 commit 624d13d
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions containerd-shim-v2/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,14 +132,6 @@ func loadSpec(r *taskAPI.CreateTaskRequest) (*specs.Spec, string, error) {
return nil, "", err
}

// Todo:
// Since there is a bug in kata for sharedPidNs, here to
// remove the pidns to disable the sharePidNs temporarily,
// once kata fixed this issue, we can remove this line.
// For the bug, please see:
// https://github.com/kata-containers/runtime/issues/930
removeNamespace(&ociSpec, specs.PIDNamespace)

return &ociSpec, bundlePath, nil
}

Expand Down

0 comments on commit 624d13d

Please sign in to comment.