Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Cloud Hypervisor: Improve analysis of failed starts #2271

Closed
ericooper opened this issue Nov 26, 2019 · 0 comments
Closed

Cloud Hypervisor: Improve analysis of failed starts #2271

ericooper opened this issue Nov 26, 2019 · 0 comments
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.

Comments

@ericooper
Copy link
Contributor

Which feature do you think can be improved?

In the unlikely event the cloud-hypervisor doesn't start properly it is at present not possible to see at runtime in the log or journal why this happened because stdout and stderr aren't captured for the cloud-hypervisor fork/exec.

How can it be improved?

In golang it is supported to capture the output in a bytebuffer and use the content of the bytebuffer to print a suitable logging messsage supporting analysis of the root-cause as it should.

Additional Information

I've prepared a fix to be included in the next upcoming PR so this one can be assigned to me.

@ericooper ericooper added enhancement Improvement to an existing feature needs-review Needs to be assessed by the team. labels Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.
Projects
None yet
Development

No branches or pull requests

1 participant