Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

AArch64: fix golint error on ARM CI. #2434

Closed
Pennyzct opened this issue Feb 4, 2020 · 0 comments
Closed

AArch64: fix golint error on ARM CI. #2434

Pennyzct opened this issue Feb 4, 2020 · 0 comments
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@Pennyzct
Copy link
Contributor

Pennyzct commented Feb 4, 2020

Description of problem

Recently, ARM CI frequently failed on the following golint error:
http://jenkins.katacontainers.io/job/kata-containers-runtime-ARM-18.04-PR/1451/console

11:24:18 pkg/rootless/rootless.go:57:2: comment on exported var `IsRootless` should be of the form `IsRootless ...` (golint)
11:24:18 	//The function is declared this way for mocking in unit tests
11:24:18 	^
11:24:23 Build step 'Execute shell' marked build as failure

The fix PR is on the fly~~~~~
@Pennyzct Pennyzct added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Feb 4, 2020
Pennyzct added a commit to Pennyzct/runtime that referenced this issue Feb 4, 2020
@Pennyzct
AArch64: arm ci failed on stale Gopkg.lock.
96a49a8 
Arm CI failed on the following error:

Gopkg.lock is out of sync:
github.com/opencontainers/runc/libcontainer/system:
imported or required, but missing from Gopkg.lock's input-imports.

Fixes: kata-containers#2434

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
@chavafg chavafg closed this as completed in 9bf4b85 Feb 4, 2020
dong-liuliu pushed a commit to dong-liuliu/runtime that referenced this issue Feb 8, 2020
@Pennyzct @dong-liuliu
AArch64: fix golint error on ARM CI.
b3abb5a 
Recently, ARM CI frequently failed on the following golint error:

Error: pkg/rootless/rootless.go:57:2: comment on exported var
`IsRootless` should be of the form `IsRootless ...` (golint)

Fixes: kata-containers#2434

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
dong-liuliu pushed a commit to dong-liuliu/runtime that referenced this issue Feb 8, 2020
@Pennyzct @dong-liuliu
AArch64: arm ci failed on stale Gopkg.lock.
a6107c4 
Arm CI failed on the following error:

Gopkg.lock is out of sync:
github.com/opencontainers/runc/libcontainer/system:
imported or required, but missing from Gopkg.lock's input-imports.

Fixes: kata-containers#2434

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
evanfoster pushed a commit to evanfoster/runtime that referenced this issue Mar 9, 2020
@Pennyzct
AArch64: fix golint error on ARM CI.
c7e24bf 
Recently, ARM CI frequently failed on the following golint error:

Error: pkg/rootless/rootless.go:57:2: comment on exported var
`IsRootless` should be of the form `IsRootless ...` (golint)

Fixes: kata-containers#2434

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
evanfoster pushed a commit to evanfoster/runtime that referenced this issue Mar 9, 2020
@Pennyzct
AArch64: arm ci failed on stale Gopkg.lock.
1866ad2 
Arm CI failed on the following error:

Gopkg.lock is out of sync:
github.com/opencontainers/runc/libcontainer/system:
imported or required, but missing from Gopkg.lock's input-imports.

Fixes: kata-containers#2434

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Pennyzct