This repository has been archived by the owner on May 12, 2021. It is now read-only.
Update data collection script based on review feedback #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Look for other runtime packages (Clear Containers and `runv`-based) in data collection script. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Fix bug where collect script was looking for Clear Containers images rather than Kata Containers ones. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Don't hard-code the architecture when looking for hypervisor packages. Fixes kata-containers#101. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
|
lgtm |
|
lgtm |
zklei
pushed a commit
to zklei/runtime
that referenced
this pull request
Jun 13, 2019
Cleanup grpc.go in order to remove some unused variables. Fixes kata-containers#102 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
zklei
pushed a commit
to zklei/runtime
that referenced
this pull request
Jun 13, 2019
We have to lock the container creation since libcontainer expects to reap the spawning process on its own. Fixes kata-containers#102 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
zklei
pushed a commit
to zklei/runtime
that referenced
this pull request
Jun 13, 2019
After the execProcess() detected that we are starting a container because the proc pointer is nil, we have to assign this pointer to the actual process held by the container structure, otherwise we end up with some segmentation fault trying to access a nil pointer. Fixes kata-containers#102 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
zklei
pushed a commit
to zklei/runtime
that referenced
this pull request
Jun 13, 2019
With recent changes and in order to support the shim connection after the container has been created, we need to initialize the exit code channel and to setup the terminal from the container creation step. StartContainer becomes a very simple function and actually fits completely the expected libcontainer behavior. Fixes kata-containers#102 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
zklei
pushed a commit
to zklei/runtime
that referenced
this pull request
Jun 13, 2019
This commit fixes an error in our OCI spec converter implemented into utils.go. Indeed, all pointers were allocated, even if the "from" value was nil. Fixes kata-containers#102 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
zklei
pushed a commit
to zklei/runtime
that referenced
this pull request
Jun 13, 2019
This commit splits execProcess() function which was doing more than only starting a process, into two more comprehensive functions. Fixes kata-containers#102 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement review feedback from @devimc on #93.
runv-based) in data collection script.Fixes #101.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com