-
Notifications
You must be signed in to change notification settings - Fork 374
versions: Add versions database #114
versions: Add versions database #114
Conversation
This is a "proof-of-concept" for what a YAML version of the Clear Containers Note that being YAML:
Example of retaining compatabilityIf we started off with this fragment for storing golang details...
... but then decided we want to move the entire
... you can query the minimum golang version using either of the following queries:
/cc @grahamwhaley, @sboeuf, @jcvenegas, @erick0z, @chavafg, @bergwolf. |
versions.yaml
Outdated
- All sections *SHOULD* include a description where intent is | ||
not clear. | ||
|
||
- WARNING: Gotcha alert! Remember to double-quote all versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you should double quote every version in this file ? No confusion this way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. It might be overkill, but I've gone for the nuclear option - all strings are quoted for maximum safety.
087a92f
to
fe1f72b
Compare
Branch updated. The contents of this file is basically verbatim what we had in CC. Although we might need to adjust (or even remove) some values subsequently, there is no harm in merging this. |
fe1f72b
to
634d544
Compare
Ping @kata-containers/runtime. |
634d544
to
bcc59d4
Compare
@jodh-intel this looks great, I wonder if we could generalize the format for all the dependencies and have a template in the comments. If we have an standar format. Then we could use it for our release notes. <group>:
description:<>
<project>:
url:<URL>
commit:<commit>
version:<>
description:"<>"
meta:
<key>: "<val>" |
bcc59d4
to
146eca4
Compare
@jcvenegas - I like it! Branch updated! |
hypervisor: | ||
description: "Component used to create virtual machines" | ||
|
||
qemu: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related: kata-containers/tests#163.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice progression of our formalisation and automation...
lgtm
versions.yaml
Outdated
url: "https://github.com/opencontainers/runtime-spec/releases" | ||
version: "v1.0.0-rc5" | ||
|
||
# vim:ts=2:expandtab:tw=70 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the vim line does no harm ;-) (and I am a vim user... )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ick - I'd forgotten that was there - removing!
146eca4
to
07410aa
Compare
Add a YAML format database that is the equivalent of the Clear Containers `versions.txt` file [1]. The file defines the versions of important non-golang dependencies used by this and other Kata repositories particularly for testing and packaging. Defining all version details centrally in this file avoids duplication and "bit-rot" when versions need to be changed. [1] - https://github.com/clearcontainers/runtime/blob/master/versions.txt Fixes kata-containers#11. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
07410aa
to
a7c7f92
Compare
Another thought... considering the
Iff we do that, we'll have to maintain both those versions though. And that would imply we'd need to test with both versions regularly. It also suggests we could abstract "version" into something like a
We could then define entries like this:
This might be too much complexity though since the only two entries that currently specify multiple versions are docker (for swarm) and golang (and that meta entry could be dropped). |
grpc.WithTimeout deprecated. Replace it with DialContext and context.WithTimeout. Fixes: kata-containers#114 Signed-off-by: Ruidong Cao <caoruidong@huawei.com>
Add a YAML format database that is the equivalent of the Clear
Containers
versions.txt
file [1].The file defines the versions of important non-golang dependencies used
by this and other Kata repositories particularly for testing and packaging.
Defining all version details centrally in this file avoids duplication
and "bitrot" when versions need to be changed.
[1] - https://github.com/clearcontainers/runtime/blob/master/versions.txt
Fixes #11.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com