This repository has been archived by the owner on May 12, 2021. It is now read-only.
config: Disable jailer by default for firecracker #2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,7 +16,7 @@ path = "@FCPATH@" | |||
| # If the jailer path is not set kata will launch firecracker | |||
| # without a jail. If the jailer is set firecracker will be | |||
| # launched in a jailed enviornment created by the jailer | |||
| jailer_path = "@FCJAILERPATH@" | |||
| #jailer_path = "@FCJAILERPATH@" | |||
There was a problem hiding this comment.
can we update the comment to note why it is disabled by default?
There was a problem hiding this comment.
@grahamwhaley I have added a comment. @egernst Let me know if that looks ok to you.
Comment out jailer path so that it is disabled by default. Fixes kata-containers#2228 Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
amshinde
force-pushed
the
disable-jailer
branch
from
ff2a89e to
fab759d
Compare
|
/test |
chavafg
approved these changes
Nov 20, 2019
Codecov Report
@@ Coverage Diff @@
## master #2229 +/- ##
=========================================
Coverage ? 49.78%
=========================================
Files ? 111
Lines ? 16616
Branches ? 0
=========================================
Hits ? 8272
Misses ? 7278
Partials ? 1066 |
egernst
approved these changes
Nov 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comment out jailer path so that it is disabled by default.
Fixes #2228
Signed-off-by: Archana Shinde archana.m.shinde@intel.com