shimv2 : Remove workaround for sharedPidNs #2794
Conversation
Removing code that existed as a workaround for a bug in how shared process namespaces were handled in the agent. That has been long fixed in the agent. With this, sharedPidNs will now work with shimv2. Fixes kata-containers#2788 Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
|
Thank you for raising your pull request. Please note that the main development of Kata Containers has moved to the 2.0-dev branch of https://github.com/kata-containers/kata-containers repository. The kata-containers/runtime repository is kept for 1.x release maintenance. Please check twice if your change should go to the 2.0-dev branch directly. If it is strongly required for adding the change to Kata Containers 1.x releases, please ping @kata-containers/runtime to assign a dedicated developer to be responsible for porting the change to 2.0-dev branch. Thanks! |
Function removeNamespace is no longer used. Get rid of it. Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
amshinde
force-pushed
the
remove-workaround-sharedpid
branch
from
94c2e25 to
e0dc806
Compare
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #2794 +/- ##
==========================================
- Coverage 50.61% 50.60% -0.02%
==========================================
Files 118 118
Lines 17310 17312 +2
==========================================
- Hits 8762 8761 -1
- Misses 7474 7477 +3
Partials 1074 1074 |
|
It's LGTM to this modification, but I think there is an issue with sharedPidNs in the guest, and the init process shared by the containers wouldn't reap the zombie child process which would cause resources leak. |
Is there as easy way to reproduce this? Do you know what needs to be done to fix this. I can take a look at it. |
|
ping @kata-containers/runtime |
Removing code that existed as a workaround for a bug in
how shared process namespaces were handled in the agent.
That has been long fixed in the agent.
With this, sharedPidNs will now work with shimv2.
Fixes #2788
Signed-off-by: Archana Shinde archana.m.shinde@intel.com