unittest: tiny fix for incorrect parameters

[keloyang]

runCommand([]string{"docker", "image", "inspect", testDockerImage}) will always fail, and it lead testcase pull busybox every time whether it exists or not.

Fixes #347

Signed-off-by: y00316549 yangshukui@huawei.com

[katabuilder]

PSS Measurement:
Qemu: 144251 KB
Proxy: 6695 KB
Shim: 11102 KB

Memory inside container:
Total Memory: 2045972 KB
Free Memory: 2014588 KB

[jodh-intel]

Hi @keloyang - I'm a little confused since the following two commands appear to be equivalent, atleast using docker 18.03.1-ce...?!

• docker image inspect $image
• docker inspect $image

[WeiZhang555]

Guess you are trying to test it with an older version of docker? @keloyang

[sboeuf]

@jodh-intel yeah I guess @keloyang is trying to use a command that works both for old Docker versions as well as more recent ones like 18.03

[jodh-intel]

@keloyang - it would be useful for us to know which version of docker you're targetting here as we try to keep track of that:

• https://github.com/kata-containers/runtime/blob/master/versions.yaml#L126..L132

Would it be docker-1.11.2 again by any chance (#334)? 😄

[amshinde]

@keloyang Yes, curious about the docker version where this is failing.
If we decide to to go with docker inspect, a more specific check with docker inspect --type=image busybox should be used, rather than looking for any docker object.

[keloyang]

@amshinde @jodh-intel @WeiZhang555 the version I used is 1.11.2, maybe it's better to use compatible command， WDYT ?

[WeiZhang555]

I think it makes sense to use a more compatible command. As @amshinde said, docker inspect --type=image busybox can be a better improvement.
The change will be LGTM with @amshinde 's suggested modification.

[amshinde]

@keloyang Agree on using a more compatible command.

[codecov]

Codecov Report

Merging #348 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #348   +/-   ##
=======================================
  Coverage   63.74%   63.74%           
=======================================
  Files          87       87           
  Lines        8731     8731           
=======================================
  Hits         5566     5566           
  Misses       2569     2569           
  Partials      596      596

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f5f619...c10db01. Read the comment docs.

[keloyang]

ping @amshinde @WeiZhang555 added --type=image, thanks.

[sboeuf]

I have restarted the failing builds and opened kata-containers/tests#367 related to the CI failure.

[katabuilder]

PSS Measurement:
Qemu: 161983 KB
Proxy: 4636 KB
Shim: 8799 KB

Memory inside container:
Total Memory: 2045972 KB
Free Memory: 1997500 KB

[jodh-intel]

lgtm

[jodh-intel]

pullapprove seems to be confused. We have the requisite number of acks and the CI is green, so merging...