This repository has been archived by the owner on May 12, 2021. It is now read-only.
create/run: Make bundle path default to cwd #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
Codecov Report
@@ Coverage Diff @@
## stable-1.1 #836 +/- ##
==============================================
- Coverage 65.2% 65.18% -0.03%
==============================================
Files 80 80
Lines 8238 8244 +6
==============================================
+ Hits 5372 5374 +2
- Misses 2320 2322 +2
- Partials 546 548 +2 |
amshinde
approved these changes
Oct 19, 2018
|
/test |
jodh-intel
force-pushed
the
stable-1.1-fix-default-bundle-path
branch
2 times, most recently
from
5b7f143 to
746060f
Compare
|
/test |
This was referenced Oct 25, 2018
|
Blocked on kata-containers/tests#856. |
|
LGTM.
@jodh-intel the bloker PR has been merged but it is targeted at the master branch of tests repo. Do you mean we use the tests repo master branch to validate stable-1.1? |
|
I see. Thanks @jodh-intel ! |
|
@jodh-intel any progress on this? |
|
¡mañana! Well, Monday maybe ;) |
|
I think #856 has merged - cannot tell if the other bits are fixed, but let's do a... |
The bundle path was documented as defaulting to the current directory but was not being set to that value if not explicitly specified. Fixes kata-containers#821. (cherry picked from commit 8831245) Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel
force-pushed
the
stable-1.1-fix-default-bundle-path
branch
from
746060f to
2061ad7
Compare
egernst
pushed a commit
to egernst/runtime
that referenced
this pull request
Feb 9, 2021
Fix potential major:minor conflicts during device updates
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bundle path was documented as defaulting to the current directory
but was not being set to that value if not explicitly specified.
Fixes #821.
(cherry picked from commit 8831245)
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com