CI: Move from qemu 2.7 to qemu 2.11 #182
Conversation
.ci/install_qemu.sh
Outdated
|
|
||
| echo "Build Qemu" | ||
| ./configure.sh | ||
| make |
chavafg
force-pushed
the
topic/qemu2-11
branch
5 times, most recently
from
6ed9d0c to
712e866
Compare
.ci/install_qemu.sh
Outdated
| # qemu under /usr/bin/, create a symlink. | ||
| # this should be solved when we define and have the packages | ||
| # in a repository. | ||
| sudo ln -sf $(command -v qemu-system-x86_64) /usr/bin/ |
There was a problem hiding this comment.
Hard-coded architecture.
.ci/install_qemu.sh
Outdated
| git checkout "$KATA_QEMU_BRANCH" | ||
|
|
||
| echo "Build Qemu" | ||
| ./configure.sh |
There was a problem hiding this comment.
I see that we have an old version of the configuration script in the qemu branch.
But as noted in kata-containers/linux#5 (comment), we should be using the script from the packaging repo, which will be:
There was a problem hiding this comment.
Opened kata-containers/packaging#10 to address this.
|
@chavafg kata-containers/packaging#10 has been merged, please modify this PR accordingly. |
|
@jcvenegas @grahamwhaley @jodh-intel Please review the PR as it now relies on latest script from kata-containers/packaging/pull/10 |
.ci/install_qemu.sh
Outdated
|
|
||
| echo "Build Qemu" | ||
| # Patch to not fail on --disable-static | ||
| curl https://raw.githubusercontent.com/clearcontainers/packaging/master/qemu-lite/configure.patch | patch -p1 |
There was a problem hiding this comment.
unknown/unsupported options should not be ignored, using https://github.com/kata-containers/qemu/blob/stable-2.11/configure.sh this patch is not needed
There was a problem hiding this comment.
@devimc we have agreed to use github.com/qemu/qemu instead of the kata-containers/qemu repo and use https://github.com/kata-containers/packaging/blob/master/scripts/configure-hypervisor.sh as the configurion options.
I have opened kata-containers/packaging#12 to fix this, then I can remove the patch here.
|
@chavafg could you try to address @jodh-intel comment ? |
Instead of using a custom version of qemu, we should use qemu version from upstream. Fixes kata-containers#163. Depends-on: github.com/kata-containers/runtime#119 Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
|
lgtm |
|
lgtm |
| git checkout "$KATA_QEMU_BRANCH" | ||
|
|
||
| echo "Build Qemu" | ||
| eval "./${QEMU_CONFIG_SCRIPT}" "qemu" | xargs ./configure |
|
fwiw, lgtm ;) |
Instead of using a custom version of qemu, we should
use qemu version from upstream.
Fixes #163.
Signed-off-by: Salvador Fuentes salvador.fuentes@intel.com