This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
modules: Verification for go modules #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we move to go modules, perform the dep check for repos that still use dep. Run `go mod verify` instead for go modules. Note, this just verifies the integrity of modules in the local cache. We would have instead wanted to verify the vendored code here, but that is still not supported. golang/go#27348 Fixes #1879 Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
|
/test |
ganeshmaharaj
approved these changes
Aug 1, 2019
jodh-intel
approved these changes
Aug 1, 2019
| @@ -780,6 +780,17 @@ static_check_vendor() | |||
| local vendor_files | |||
| local result | |||
|
|
|||
| # Check if repo has been changed to use go modules | |||
| if [ -f "go.mod" ]; then | |||
| info "go.mod file found, running go mod verify instead" | |||
There was a problem hiding this comment.
Nit: You could define a variable for go.mod to avoid the duplication.
|
ARM CI fell over with: ... which is fixed by kata-containers/osbuilder#339 (so this PR is blocked on that PR :) Restarted CentOS CI which suffered a network timeout. |
|
Thanks @jodh-intel Will rerun ARM CI once that is merged. |
|
/test |
|
@amshinde errors in kubernetes tests |
|
The error on centos was not related with this PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we move to go modules, perform the dep check for repos
that still use dep.
Run
go mod verifyinstead for go modules.Note, this just verifies the integrity of modules in the local
cache. We would have instead wanted to verify the vendored code
here, but that is still not supported.
golang/go#27348
Fixes #1879
Signed-off-by: Archana Shinde archana.m.shinde@intel.com