-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix get_tree_diff for sep #308
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aining forbidden symbols, and different for tree and other_tree
kayjan
added
bug
Something isn't working
enhancement
New feature or request
breaking
New feature or request that is not backwards-compatible
labels
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 0dcc7f2 | Previous: c1c55a9 | Ratio |
---|---|---|---|
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 |
15732.93036068191 iter/sec (stddev: 0.000017433646979216072 ) |
14872.442776582864 iter/sec (stddev: 0.000017674911815836655 ) |
0.95 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 |
694.9282158252272 iter/sec (stddev: 0.000006820681302020576 ) |
695.9463110831024 iter/sec (stddev: 0.000020245810648049474 ) |
1.00 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 |
12.372578035680599 iter/sec (stddev: 0.0030353736622349796 ) |
12.166371635500242 iter/sec (stddev: 0.0038396942615142294 ) |
0.98 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 |
68.16188021221322 iter/sec (stddev: 0.003699244116440926 ) |
69.26692821905407 iter/sec (stddev: 0.0032167182673380483 ) |
1.02 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions |
21844.172410059597 iter/sec (stddev: 0.0000012602057026830497 ) |
21455.98144503469 iter/sec (stddev: 6.844086526104986e-7 ) |
0.98 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions |
1544.5254642430448 iter/sec (stddev: 0.000100678782742315 ) |
1667.7281756503478 iter/sec (stddev: 0.00005540393762879646 ) |
1.08 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions |
112.5687139833065 iter/sec (stddev: 0.003758679623381361 ) |
109.12564160011736 iter/sec (stddev: 0.003989757664698673 ) |
0.97 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions |
91.91239111248214 iter/sec (stddev: 0.003509221543364949 ) |
95.41012286996879 iter/sec (stddev: 0.0028603633903862766 ) |
1.04 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
New feature or request that is not backwards-compatible
bug
Something isn't working
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
get_tree_diff can now handle
Testing
Add test cases for all the above
Additional notes
Checklist
I have read through the contributing guidelines and ensured that
Checklist (for reviewer)