Add admin mode to PermissionsChecker #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Surprised it's not already there. Anyway, will be needed for the admin object metadata method and also allows us to clean up some other methods that were doing hacky things to get around it.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #701 +/- ##
=============================================
+ Coverage 87.52% 87.54% +0.01%
+ Complexity 5228 5224 -4
=============================================
Files 224 224
Lines 17385 17410 +25
Branches 2561 2560 -1
=============================================
+ Hits 15216 15241 +25
Misses 1706 1706
Partials 463 463 |
ialarmedalien
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surprised it's not already there. Anyway, will be needed for the admin object metadata method and also allows us to clean up some other methods that were doing hacky things to get around it.