correctly diff removing children by using a seperate counter for old …

…children
kbrsh · May 3, 2017 · 4b919af · 4b919af
1 parent abd312d
commit 4b919af
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/dist/moon.js b/dist/moon.js
@@ -872,8 +872,8 @@
         } else {
           // Traverse and Diff Children
           var totalLen = newLength > oldLength ? newLength : oldLength;
-          for (var i = 0; i < totalLen; i++) {
-            var oldChild = i < oldLength ? oldChildren[i] : null;
+          for (var i = 0, j = 0; i < totalLen; i++, j++) {
+            var oldChild = j < oldLength ? oldChildren[j] : null;
             var child = i < newLength ? children[i] : null;
 
             var action = diff(oldChild, child, _node, instance);
@@ -884,11 +884,11 @@
                 oldChildren[oldLength++] = child;
                 break;
               case PATCH.REMOVE:
-                oldChildren.splice(i, 1);
+                oldChildren.splice(j--, 1);
                 oldLength--;
                 break;
               case PATCH.REPLACE:
-                oldChildren[i] = children[i];
+                oldChildren[j] = children[i];
                 break;
               case PATCH.TEXT:
                 oldChild.val = child.val;