new convention for loops and string concat

kbrsh · Apr 27, 2019 · 4c28900 · 4c28900
1 parent e2c1ebe
commit 4c28900
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 9 deletions.
diff --git a/packages/moon/dist/moon.js b/packages/moon/dist/moon.js
@@ -131,9 +131,10 @@
 				}
 			} else {
 				var tag = "<" + token.value;
+				var attributes = token.attributes;
 
-				for (var attributeKey in token.attributes) {
-					var attributeValue = token.attributes[attributeKey];
+				for (var attributeKey in attributes) {
+					var attributeValue = attributes[attributeKey];
 					tag += " " + attributeKey + "=" + (isQuote(attributeValue[0]) ? attributeValue : "{" + attributeValue + "}");
 				}
 

diff --git a/packages/moon/src/compiler/lexer/lexer.js b/packages/moon/src/compiler/lexer/lexer.js
@@ -33,7 +33,7 @@ function scopeExpression(expression) {
 	return expression.replace(expressionRE, (match, name) =>
 		(name === undefined || globals.indexOf(name) !== -1) ?
 			match :
-			`data.${name}`
+			"data." + name
 	);
 }
 
@@ -57,10 +57,11 @@ export function tokenString(token) {
 				return `{${content}}`;
 			}
 		} else {
-			let tag = `<${token.value}`;
+			let tag = "<" + token.value;
+			const attributes = token.attributes;
 
-			for (let attributeKey in token.attributes) {
-				const attributeValue = token.attributes[attributeKey];
+			for (let attributeKey in attributes) {
+				const attributeValue = attributes[attributeKey];
 				tag += ` ${attributeKey}=${isQuote(attributeValue[0]) ? attributeValue : `{${attributeValue}}`}`;
 			}
 
@@ -84,7 +85,7 @@ export function tokenString(token) {
  * @param {number} index
  */
 function lexError(message, input, index) {
-	let lexMessage = `${message}\n\n`;
+	let lexMessage = message + "\n\n";
 
 	// Show input characters surrounding the source of the error.
 	for (

diff --git a/packages/moon/src/index.js b/packages/moon/src/index.js
@@ -46,7 +46,7 @@ export default function Moon(options) {
 	}
 
 	if (typeof view === "string") {
-		view = new Function("data", `return ${compile(view)}`);
+		view = new Function("data", "return " + compile(view));
 	}
 
 	// If a `root` option is given, start the root renderer, or else just return

diff --git a/packages/moon/src/util/util.js b/packages/moon/src/util/util.js
@@ -23,7 +23,7 @@ export function isQuote(char) {
  * @param {string} message
  */
 export function error(message) {
-	console.error(`[Moon] ERROR: ${message}`);
+	console.error("[Moon] ERROR: " + message);
 }
 
 /**