simplify component view executor

kbrsh · Apr 17, 2019 · b3caaf6 · b3caaf6
1 parent 78c0a58
commit b3caaf6
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 10 deletions.
diff --git a/packages/moon/dist/moon.js b/packages/moon/dist/moon.js
@@ -709,13 +709,12 @@
 
 			if (node.type === types.component) {
 				// Execute the component to get the component view.
-				var nodeComponent = components[node.name](node.data); // TODO: Update component children and component output children.
-				// Set the root view or current node to the new component view.
+				node = components[node.name](node.data); // Set the root view or current node to the new component view.
 
 				if (parent === null) {
-					setViewNew(nodeComponent);
+					setViewNew(node);
 				} else {
-					node = parent.data.children[index] = nodeComponent;
+					parent.data.children[index] = node;
 				}
 			} else if (parent === null) {
 				// If there is no parent, set the root new view to the current node.

diff --git a/packages/moon/dist/moon.min.js b/packages/moon/dist/moon.min.js
diff --git a/packages/moon/src/executor/executor.js b/packages/moon/src/executor/executor.js
@@ -117,15 +117,13 @@ function executeView(nodes, parents, indexes) {
 
 		if (node.type === types.component) {
 			// Execute the component to get the component view.
-			const nodeComponent = components[node.name](node.data);
-
-			// TODO: Update component children and component output children.
+			node = components[node.name](node.data);
 
 			// Set the root view or current node to the new component view.
 			if (parent === null) {
-				setViewNew(nodeComponent);
+				setViewNew(node);
 			} else {
-				node = parent.data.children[index] = nodeComponent;
+				parent.data.children[index] = node;
 			}
 		} else if (parent === null) {
 			// If there is no parent, set the root new view to the current node.