iterate through if siblings correctly and fix empty else clause text …

…content
kbrsh · Apr 28, 2019 · b823ad5 · b823ad5
1 parent e74b36d
commit b823ad5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/packages/moon/dist/moon.js b/packages/moon/dist/moon.js
@@ -572,7 +572,7 @@
 		if (parent !== null) {
 			var siblings = parent.children;
 
-			for (var i = index + 1; i < siblings.length; i++) {
+			for (var i = index + 1; i < siblings.length;) {
 				var sibling = siblings[i];
 
 				if (sibling.type === "else-if") {
@@ -599,7 +599,7 @@
 
 
 		if (emptyElseClause) {
-			prelude += "else{" + variable + "={type:" + types.text + ",name:\"text\",data:{children:[]}};}";
+			prelude += "else{" + variable + "={type:" + types.text + ",name:\"text\",data:{\"\":\"\",children:[]}};}";
 		}
 
 		return {

diff --git a/packages/moon/dist/moon.min.js b/packages/moon/dist/moon.min.js
diff --git a/packages/moon/src/compiler/generator/components/if.js b/packages/moon/src/compiler/generator/components/if.js
@@ -26,7 +26,7 @@ export function generateNodeIf(element, parent, index) {
 	if (parent !== null) {
 		const siblings = parent.children;
 
-		for (let i = index + 1; i < siblings.length; i++) {
+		for (let i = index + 1; i < siblings.length;) {
 			const sibling = siblings[i];
 
 			if (sibling.type === "else-if") {
@@ -66,7 +66,7 @@ export function generateNodeIf(element, parent, index) {
 
 	// Generate an empty `else` clause represented by an empty text node.
 	if (emptyElseClause) {
-		prelude += `else{${variable}={type:${types.text},name:"text",data:{children:[]}};}`;
+		prelude += `else{${variable}={type:${types.text},name:"text",data:{"":"",children:[]}};}`;
 	}
 
 	return {