Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using immutable version of the HTTP Addon #202

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

arschles
Copy link
Collaborator

@arschles arschles commented Nov 18, 2021

As of kedacore/http-add-on#327, the HTTP Addon's release process publishes new images before updating the chart. Prior to this PR, the HTTP Addon chart was using the latest tag for images. That means that during a release, an old chart was installing new images. This PR ensures that the chart is using immutable images, so that even when a release creates new images, the current version of the chart is using the proper ones.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)
  • README is updated with new configuration values (if applicable)

Fixes #

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton, a lot safer indeed!

@tomkerkhove tomkerkhove merged commit 3885a1c into kedacore:master Nov 19, 2021
@arschles
Copy link
Collaborator Author

Thanks for the review @tomkerkhove !

@arschles arschles deleted the http-add-on-vsn branch November 19, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants