Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KEDA] add relabelling support #287

Merged
merged 1 commit into from
Jul 15, 2022
Merged

[KEDA] add relabelling support #287

merged 1 commit into from
Jul 15, 2022

Conversation

bmiguel-teixeira
Copy link
Contributor

@bmiguel-teixeira bmiguel-teixeira commented Jul 15, 2022 •
edited by JorTurFer
Loading

This MR adds support to add relabelling expressions to both Operator & Metrics Server PodMonitor.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)
  • README is updated with new configuration values (if applicable)

Fixes #

@bmiguel-teixeira bmiguel-teixeira requested a review from a team as a code owner July 15, 2022 07:35
JorTurFer
JorTurFer reviewed Jul 15, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!
Could you sign your commit? https://github.com/kedacore/keda/blob/main/CONTRIBUTING.md#i-didnt-sign-my-commit-now-what

@bmiguel-teixeira
Copy link
Contributor Author

Hi @JorTurFer
Commit signed.

@JorTurFer
Copy link
Member

Please, add also the information of the parameter in the chart readme file please https://github.com/kedacore/charts/blob/main/keda/README.md

@bmiguel-teixeira @brunomiguel-teixeira
[FEAT] add relabelling support
675831d 
Signed-off-by: Bruno Teixeira <bmiguel.teixeira@outlook.pt>
@bmiguel-teixeira
Copy link
Contributor Author

Hi @JorTurFer
Good catch. Missed it!. Added description to readme & squashed.

JorTurFer
JorTurFer approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! ❤️

@JorTurFer JorTurFer changed the title [FEAT] add relabelling support [KEDA] add relabelling support Jul 15, 2022
@JorTurFer JorTurFer merged commit c26fcc1 into kedacore:main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmiguel-teixeira @JorTurFer