Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for the scaler queue pinger #139

Closed
arschles opened this issue Apr 14, 2021 · 2 comments · Fixed by #291
Closed

Add tests for the scaler queue pinger #139

arschles opened this issue Apr 14, 2021 · 2 comments · Fixed by #291
Labels
good first issue Good for newcomers testing

Comments

@arschles
Copy link
Collaborator

arschles commented Apr 14, 2021 •
edited
Loading

The scaler has very little testing (it will have slightly more after #116). This issue is to add tests for the scaler queue pinger.
@arschles arschles added testing good first issue Good for newcomers labels Apr 14, 2021
@arschles arschles changed the title Add tests to the scaler Add tests for the scaler queue pinger Apr 14, 2021
@arschles arschles mentioned this issue Oct 8, 2021
Merged
5 tasks
@stale
Copy link

stale bot commented Oct 14, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Oct 14, 2021
@arschles
Copy link
Collaborator Author

#291 will close this. keeping this open so that PR can close it

@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactoring concurrency in scaler's pending HTTP queue fetcher logic arschles/http-add-on
1 participant
@arschles