Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external-scaler spams log due to missing HTTPSO for dummy keda-add-ons-http-interceptor #718

Closed
jocelynthode opened this issue Jun 21, 2023 · 2 comments · Fixed by #720 or kedacore/charts#487
Labels
bug Something isn't working

Comments

@jocelynthode
Copy link
Contributor

Report

The logs of the interceptor are spammed because keda-add-ons-http-interceptor only has a ScaledObject and no accompanying HTTPSO which the external-scaler tries to get

Expected Behavior

This error should be ignored.

Actual Behavior

The error is spamming the logs

Steps to Reproduce the Problem

  1. Install the keda-http-addon
  2. Query the external-scaler logs

Logs from KEDA HTTP operator

{"level":"error","ts":1687362513.545272,"logger":"GetMetricSpec","caller":"scaler/handlers.go:117","msg":"unable to get HTTPScaledObject","name":"keda-add-ons-http-interceptor","namespace":"keda","error":"httpscaledobject.http.keda.sh \"keda-add-ons-http-interceptor\" not found","stacktrace":"main.(*impl).GetMetricSpec\n\tgithub.com/kedacore/http-add-on/scaler/handlers.go:117\ngithub.com/kedacore/keda/v2/pkg/scalers/externalscaler._ExternalScaler_GetMetricSpec_Handler\n\tgithub.com/kedacore/keda/v2@v2.10.1-0.20230601160236-b5de66fe3857/pkg/scalers/externalscaler/externalscaler_grpc.pb.go:190\ngoogle.golang.org/grpc.(*Server).processUnaryRPC\n\tgoogle.golang.org/grpc@v1.54.0/server.go:1345\ngoogle.golang.org/grpc.(*Server).handleStream\n\tgoogle.golang.org/grpc@v1.54.0/server.go:1722\ngoogle.golang.org/grpc.(*Server).serveStreams.func1.2\n\tgoogle.golang.org/grpc@v1.54.0/server.go:966"}

HTTP Add-on Version

0.5.0

Kubernetes Version

1.25

Platform

None

Anything else?

No response

@jocelynthode
Copy link
Contributor Author

Not sure if

{"level":"error","ts":1687361393.8690586,"logger":"Probe","caller":"handler/probe.go:63","msg":"health check function failed","error":"table has not synced","errorVerbose":"table has not synced\ngithub.com/kedacore/http-add-on/pkg/routing.init\n\tgithub.com/kedacore/http-add-on/pkg/routing/table.go:25\nruntime.doInit\n\truntime/proc.go:6506\nruntime.doInit\n\truntime/proc.go:6483\nruntime.doInit\n\truntime/proc.go:6483\nruntime.main\n\truntime/proc.go:233\nruntime.goexit\n\truntime/asm_amd64.s:1598","stacktrace":"github.com/kedacore/http-add-on/interceptor/handler.(*Probe).check\n\tgithub.com/kedacore/http-add-on/interceptor/handler/probe.go:63\ngithub.com/kedacore/http-add-on/interceptor/handler.(*Probe).Start\n\tgithub.com/kedacore/http-add-on/interceptor/handler/probe.go:44"}

is also related to this.

@jocelynthode jocelynthode mentioned this issue Jun 21, 2023
7 tasks
@t0rr3sp3dr0
Copy link
Contributor

This is a regression I introduced when implementing the new routing table caused by a mismatch between the manifests we have on this repo and the ones from the charts repo that made me believe the interceptor scaling was not being used. Sorry about that! I'm working on a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
2 participants