Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the external push gRPC protocol for external scaler => interceptor communication #97

Open
Tracked by #911
arschles opened this issue Mar 15, 2021 · 14 comments
Assignees
Labels
enhancement New feature or request feature good first issue Good for newcomers help wanted Extra attention is needed

Comments

@arschles
Copy link
Collaborator

We currently use a simple HTTP/JSON protocol for the scaler to communicate with the interceptor. Because this protocol is just request/response, it has limitations on latency that can cause very slow scale up times, which are especially noticeable when scaling up from 0 replicas.

It would be helpful to have some kind of two way protocol rather than what we have now. The external push scaler provides just this. We should take this and use it in the scaler.

Use-Case

As mentioned above, this would be useful to speed up scale-up (and down) latencies. This may help with #60 as well, but that's not the primary goal here.

Specification

@benjaminhuo
Copy link

Is there any plan to implement the external push interface?

@arschles
Copy link
Collaborator Author

@benjaminhuo we would likely implement the external push interface or something similar but simpler (because my guess is we won't need all the complexity of the current external push interface)

@benjaminhuo
Copy link

Looking forward to seeing this added!

@arschles
Copy link
Collaborator Author

Same here @benjaminhuo. @ajanth97 and I are going to come up with a design in the near future and the current plan is he's going to implement it. This will probably all start in earnest after the big #206 is merged.

Let me know if you'd like to get involved - you're certainly welcome to!

@benjaminhuo
Copy link

@arschles Yes sure, I'm happy to get involved!

@arschles
Copy link
Collaborator Author

ok. let's start by collaborating on a design. I've started a document here. feel free to leave comments etc...

Note: If you haven't used hackmd before, you have to login with your GitHub (or it supports some other SSO types I think) account before you can edit or comment.

@ajanth97
Copy link
Collaborator

Awesome

@benjaminhuo
Copy link

benjaminhuo commented Aug 20, 2021

ok. let's start by collaborating on a design. I've started a document here. feel free to leave comments etc...

Note: If you haven't used hackmd before, you have to login with your GitHub (or it supports some other SSO types I think) account before you can edit or comment.

@arschles That's a great place to start!
@tpiperatgod @wanjunlei you can also take a look at this doc https://hackmd.io/ttpSY5KQQtGIqbAzyKex3g if you're interested

@stale
Copy link

stale bot commented Oct 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Oct 19, 2021
@arschles
Copy link
Collaborator Author

This is ongoing. @ajanth97 is working on it

@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Oct 19, 2021
@arschles arschles added this to the v0.3.0 milestone Nov 16, 2021
@arschles arschles mentioned this issue Nov 18, 2021
2 tasks
@tomkerkhove
Copy link
Member

tomkerkhove commented May 11, 2022

Any update on this? Is it still relevant?

@tomkerkhove tomkerkhove removed this from the v0.4.0 milestone May 11, 2022
@ajanth97
Copy link
Collaborator

Hi Sorry, I will work on this soon

@tomkerkhove
Copy link
Member

Great, thanks!

@arschles
Copy link
Collaborator Author

Is it still relevant?

FWIW, I think it still is 😄

kingdonb pushed a commit to kingdonb/http-add-on that referenced this issue Jun 12, 2023
@JorTurFer JorTurFer mentioned this issue Apr 4, 2024
19 tasks
@JorTurFer JorTurFer added the help wanted Extra attention is needed label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: To Do
Development

No branches or pull requests

5 participants