Expose service configuration

[khaosdoctor]

Adding exposed configuration, for now the only configs that can be changed are the service exposed port and type because labels are defined by the add-on.

Checklist

• Commits are signed with Developer Certificate of Origin (DCO)
• A PR is opened to update the documentation on our docs repo

Fixes #107

[khaosdoctor]

@arschles @tomkerkhove can you PTAL? Just finished

[arschles]

LGTM @khaosdoctor. Can you add documentation to the reference?

[khaosdoctor]

Will do!

[arschles]

@khaosdoctor one more thing - can you add a test for this too?

[khaosdoctor]

Commited the requested changes, but haven't done the test yet because I'm having some issues running Go in my PC, also I think we'll need to run mage manifests again to rebuild the RBAC config and CRD struct

[arschles]

@khaosdoctor will this mean we need to make changes to kedacore/charts#137 as well?

[khaosdoctor]

@khaosdoctor will this mean we need to make changes to kedacore/charts#137 as well?

Most likely yes, since the CRD will change (we may need to think in an automated way to do this)

[arschles]

@khaosdoctor in that case, do you think we need to bump the version of the CRD?

[khaosdoctor]

@khaosdoctor in that case, do you think we need to bump the version of the CRD?

This might be a good idea, since this is a breaking change I propose a major version increase

[arschles]

This might be a good idea, since this is a breaking change I propose a major version increase

would it, though? if you're just adding a new field to the spec, it won't break old HTTPScaledObjects. we could bump from v1alpha1 -> v1alpha2

[khaosdoctor]

This might be a good idea, since this is a breaking change I propose a major version increase

would it, though? if you're just adding a new field to the spec, it won't break old HTTPScaledObjects. we could bump from v1alpha1 -> v1alpha2

Agreed, we can keep the version and change the release :)

[arschles]

@khaosdoctor this looks great. I want to get the 0.1.0 release out before we merge this though. stand by :)

[khaosdoctor]

Closing it as it's gonna be superseeded by #206