Using structured logging in the interceptor #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
arschles
requested review from
ahmelsayed,
tomkerkhove and
zroubalik
as code owners
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
arschles
commented
Jun 15, 2021
| return func() error { | ||
| deployment, err := deployCache.Get(deployName) | ||
| if err != nil { | ||
| // if we didn't get the initial deployment state, bail out | ||
| return fmt.Errorf("Error getting state for deployment %s (%s)", deployName, err) | ||
| logger.Error( |
There was a problem hiding this comment.
NOTE: this block is significantly changed in https://github.com/kedacore/http-add-on/pull/181/files. The conflict should be resolved favoring the other PR
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
|
This will be superseded by #206. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the standard library's
logpackage in the interceptor, this PR uses klogr, a logr implementation for theklogrlibrary that we already depend on in this repository.The advantages of using this library -- and structured logging in general -- over the std lib
logpackage are:.WithName,WithValues) to their needsChecklist
README.mddocs/Fixes #