Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a fake controller-runtime Client implementation and improving operator tests #247

Merged
merged 56 commits into from
Oct 25, 2021
Merged

Adding a fake controller-runtime Client implementation and improving operator tests #247

merged 56 commits into from
Oct 25, 2021

Conversation

arschles
Copy link
Collaborator

@arschles arschles commented Aug 30, 2021 •
edited
Loading

This patch implements a fake version of the controller-runtime's Client interface which both records calls to its various functionality and allows the user control over most (some are not implemented) of the functions that it contains. This fake client allows us to test more of the operator's functionality.

This PR is dependent on #206 and is submitted as a draft. It should not be reviewed or merged until #206 is complete.
Update: #206 is merged, and this PR has been removed from draft mode. It is ready for review.

Checklist

Fixes #228

arschles and others added 30 commits August 18, 2021 15:05
@arschles
multi-tenant interceptor and scaler
43e8eff 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
Merge branch 'main' of github.com:kedacore/http-add-on into global-co…
cbe11ec 
…mponents

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
Merge branch 'main' of github.com:kedacore/http-add-on into global-co…
7bb4e11 
…mponents

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
specifying host in XKCD ingress
9d7fae6 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
routing the xkcd chart to the interceptor properly
e6a6d67 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
check host header first
20dac47 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
sending true active response in stream
a3c0403 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
passing target pending requests through to the underlying ScaledObjec…
ff8a3c0 
…t (so the scaler can read it later)

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
removing broken target pending requests
ee8ef79 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
using getHost in proxy handler
966e8ce 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
adding integration test
b96f209 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
adding more tests to the integration test
1123c70 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
splitting up integration tests
013915e 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
more checks
f63ad32 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
mark new test TODO
37fe73b 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
expanding interceptor integration tests
6078beb 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
error messages
18452c3 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
refactor test
9b708e0 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
more test improvements
8db0df4 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
rolling back target pending requests in ScaledObject
647eaae 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
removing target metric error. it's not used anymore
3b34131 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
improving waitFunc test
9bda86e 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
Refactoring the deployment cache to add better error handing and resi…
76117d5 
…lience.

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
adding doc comment
69d4c0f 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
refactoring deploy cache and adding tests
1039b92 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
Using interfaces for deployment watch & list
bebce95 
this makes tests easier

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
adding more deploy cache tests
904b754 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
Fixing up TestK8sDeploymentCacheRewatch
0c1dd47 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
shutting down everything else when one thing errors, and adding a dep…
ae28597 
…loyments cache endpoint

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
removing commented code
a083ac7 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
running the global test target with sh.RunV
b45fd22 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
adding timeout to magefile test target
570e259 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
finishing one TODO test and adding issue for the rest:
0a3b321 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles
implementing a fake controller-runtime client
1b149c8 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles arschles changed the title check operator cfg maps Adding a fake controller-runtime Client implementation and improving operator tests Aug 30, 2021
@arschles arschles mentioned this pull request Aug 30, 2021
Merged
29 tasks
@arschles
Merge branch 'main' of github.com:kedacore/http-add-on into check-ope…
e2b7940 
…rator-cfg-maps

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles arschles marked this pull request as ready for review September 7, 2021 20:57
@arschles arschles requested a review from ajanth97 as a code owner September 13, 2021 17:27
@arschles arschles enabled auto-merge (squash) September 13, 2021 17:56
@arschles arschles added this to the v0.2.0 milestone Sep 22, 2021
bketelsen
bketelsen approved these changes Oct 25, 2021
View reviewed changes
Copy link

@bketelsen bketelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arschles arschles disabled auto-merge October 25, 2021 18:36
@arschles
Copy link
Collaborator Author

Thanks @bketelsen!

Even though the linkinator check is failing, I am still going to merge this. The work to fix this is in kedacore/keda#2215 and will be done separately.

@arschles arschles merged commit 119e0ea into kedacore:main Oct 25, 2021
@arschles arschles deleted the check-operator-cfg-maps branch October 25, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bketelsen bketelsen bketelsen approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

@tomkerkhove tomkerkhove Awaiting requested review from tomkerkhove

@zroubalik zroubalik Awaiting requested review from zroubalik

@ajanth97 ajanth97 Awaiting requested review from ajanth97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

Check for config maps to be changed in the operator routing table tests
2 participants
@arschles @bketelsen