Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling host value of "interceptor" in GetMetricSpec #273

Merged
merged 5 commits into from
Oct 8, 2021

Conversation

ajanth97
Copy link
Collaborator

@ajanth97 ajanth97 commented Sep 28, 2021

This PR should fix issue #272

Checklist

Fixes #272

@ajanth97 ajanth97 requested a review from arschles September 28, 2021 19:43
Signed-off-by: Ajanth <ajanth1997@gmail.com>
@arschles
Copy link
Collaborator

@ajanth97 looks good so far!

@ajanth97
Copy link
Collaborator Author

@arschles thanks for the review.

@arschles arschles changed the title Fixing issue #272 Handling host value of "interceptor" in GetMetricSpec Sep 30, 2021
@arschles
Copy link
Collaborator

arschles commented Oct 1, 2021

@ajanth97 absolutely. let me know when you take this out of draft. I'm happy to give it a second review.

@arschles arschles added this to the v0.2.0 milestone Oct 5, 2021
@ajanth97 ajanth97 marked this pull request as ready for review October 8, 2021 15:48
@ajanth97 ajanth97 enabled auto-merge (squash) October 8, 2021 15:53
Copy link
Collaborator

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ajanth97 - I'll add tests for this in a follow-up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External scaler GetMetricSpec function cannot handle "interceptor" host
2 participants