Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding config endpoints on admin servers for scaler, interceptor and operator #280

Merged
merged 10 commits into from
Oct 25, 2021
Merged

Adding config endpoints on admin servers for scaler, interceptor and operator #280

merged 10 commits into from
Oct 25, 2021

Conversation

arschles
Copy link
Collaborator

@arschles arschles commented Sep 29, 2021 •
edited
Loading

Adding endpoints to fetch configuration from interceptor, scaler and operator

Checklist

Fixes #278

@arschles
adding config endpoint to interceptor
1a392b6 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
adding documentation about configuration endpointss
1910da7 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
adding operator and scaler config endpoints
7ca915f 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
testing scaler and operator
875ca8c 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles arschles marked this pull request as ready for review September 30, 2021 21:38
@arschles
Copy link
Collaborator Author

@ajanth97 this is now ready for review. can you please take a look?

@arschles arschles enabled auto-merge (squash) September 30, 2021 21:38
@arschles arschles mentioned this pull request Sep 30, 2021
Merged
5 tasks
@arschles
serving operator and scaler admin servers on random ports for tests
8a0b664 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
implementing json.Marshaler for FakeDeploymentCache
4b94fe2 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
implementing TestRunAdminServerDeploymentsEndpoint
8fcc313 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
Copy link
Collaborator Author

Expected to conflict with #279. I'll take care of resolving conflicts as necessary

@arschles arschles added this to the v0.2.0 milestone Sep 30, 2021
bketelsen
bketelsen approved these changes Oct 25, 2021
View reviewed changes
Copy link

@bketelsen bketelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice ErrGroup usage. LGTM

@arschles arschles disabled auto-merge October 25, 2021 18:34
@arschles
Copy link
Collaborator Author

arschles commented Oct 25, 2021 •
edited
Loading

Thanks @bketelsen!

I'm going to manually merge this even though the linkinator check is failing. That issue is captured in kedacore/keda#2215 and will be worked on separately.

@arschles arschles merged commit a3aeb62 into kedacore:main Oct 25, 2021
@arschles arschles deleted the admin-config branch October 25, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bketelsen bketelsen bketelsen approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

@ajanth97 ajanth97 Awaiting requested review from ajanth97

@tomkerkhove tomkerkhove Awaiting requested review from tomkerkhove

@zroubalik zroubalik Awaiting requested review from zroubalik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

Add admin endpoints for the configurations of each component
2 participants
@arschles @bketelsen