Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using ServeContext for all production HTTP servers #292

Merged
merged 8 commits into from
Oct 25, 2021
Merged

using ServeContext for all production HTTP servers #292

merged 8 commits into from
Oct 25, 2021

Conversation

arschles
Copy link
Collaborator

@arschles arschles commented Oct 7, 2021

This patch replaces all http.ListenAndServe function calls with (github.com/kedacore/http-add-on/pkg/http).ServeContext calls.

Checklist

Fixes #

@arschles
using ServeContext for all production HTTP servers
696f688 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles arschles added the enhancement New feature or request label Oct 7, 2021
@arschles arschles added this to the v0.2.0 milestone Oct 7, 2021
@arschles arschles enabled auto-merge (squash) October 8, 2021 15:55
ajanth97
ajanth97 approved these changes Oct 21, 2021
View reviewed changes
Copy link
Collaborator

@ajanth97 ajanth97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

bketelsen
bketelsen approved these changes Oct 25, 2021
View reviewed changes
Copy link

@bketelsen bketelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arschles arschles disabled auto-merge October 25, 2021 18:33
@arschles
Copy link
Collaborator Author

Thanks @bketelsen !

I'm going to merge this even though the linkinator check is broken. The fix for it is detailed in kedacore/keda#2215 and that work will be done separately.

@arschles arschles merged commit 30fb204 into kedacore:main Oct 25, 2021
@arschles arschles deleted the serve-http branch October 25, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajanth97 ajanth97 ajanth97 approved these changes

@bketelsen bketelsen bketelsen approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

@tomkerkhove tomkerkhove Awaiting requested review from tomkerkhove

@zroubalik zroubalik Awaiting requested review from zroubalik

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@arschles @bketelsen @ajanth97