Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calling fetchAndSaveCounts in the scaler after any interceptor deployment events #386

Merged
merged 5 commits into from
Feb 17, 2022

Conversation

arschles
Copy link
Collaborator

This pull request adds functionality to the scaler that watches the interceptor Deployment and, when any events come into the scaler for that Deployment, the scaler will immediately call fetchAndSaveCounts to get updated information on queue counts from each interceptor in the newly changed Deployment

Checklist

Fixes #284

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles arschles changed the title adding deployment cache to the scaler calling fetchAndSaveCounts in the scaler after any interceptor deployment events Jan 27, 2022
@arschles arschles marked this pull request as ready for review February 15, 2022 21:13
Copy link

@bketelsen bketelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arschles arschles added this to the v0.4.0 milestone Feb 17, 2022
@arschles arschles merged commit 6526950 into kedacore:main Feb 17, 2022
@arschles arschles deleted the request-counts-scaler branch February 17, 2022 23:41
@JorTurFer JorTurFer added this to the v0.4.0 milestone Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have the scaler call requestCounts immediately after the interceptor Deployment changes # of replicas
3 participants